Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iOS): Elevator alerts on nearby & unfiltered #673

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

EmmaSimon
Copy link
Contributor

Summary

Ticket:  | Elevator Status | Elevator alerts in nearby transit & stop details

Add elevator closure alerts to nearby transit and the unfiltered stop details page. Also update the alert details page to support not having a specified line or route for displaying stop specific elevator alerts.

Simulator Screenshot - iPhone 15 - 2025-01-22 at 12 48 08 Simulator Screenshot - iPhone 15 - 2025-01-22 at 12 48 19 Simulator Screenshot - iPhone 15 - 2025-01-22 at 12 48 31

iOS

  • If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?
    • Add temporary machine translations, marked "Needs Review"

android
- [ ] All user-facing strings added to strings resource
- [ ] Expensive calculations are run in withContext(Dispatchers.Default) where possible

Testing

Added unit tests for new behavior

@EmmaSimon EmmaSimon requested a review from a team as a code owner January 22, 2025 18:06
@EmmaSimon EmmaSimon requested a review from BrandonTR January 22, 2025 18:06
@EmmaSimon EmmaSimon mentioned this pull request Jan 22, 2025
2 tasks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@EmmaSimon EmmaSimon merged commit adf4db9 into main Jan 23, 2025
7 checks passed
@EmmaSimon EmmaSimon deleted the es-ios-elevator-alerts-nearby branch January 23, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants