Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iOS): Add elevator alerts to stop page #677

Merged
merged 9 commits into from
Jan 24, 2025

Conversation

EmmaSimon
Copy link
Contributor

@EmmaSimon EmmaSimon commented Jan 23, 2025

Summary

Ticket:  | Elevator Status | Elevator alerts in trip details

Adds elevator alerts to the stop details page when the elevator information feature toggle is turned on. Also updates the alert analytics event with a new elevator field.

Simulator Screenshot - iPhone 15 - 2025-01-23 at 10 55 38

iOS
- [ ] If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?
- [ ] Add temporary machine translations, marked "Needs Review"

Testing

Added unit test

@EmmaSimon EmmaSimon marked this pull request as ready for review January 23, 2025 16:32
@EmmaSimon EmmaSimon requested a review from a team as a code owner January 23, 2025 16:32
@EmmaSimon EmmaSimon requested a review from JackVCurtis January 23, 2025 16:32
@EmmaSimon EmmaSimon merged commit 5889894 into main Jan 24, 2025
7 checks passed
@EmmaSimon EmmaSimon deleted the es-ios-elevator-alerts-stop branch January 24, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants