setup and test scripts #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathcolo
reviewed
Jun 3, 2024
| #!/usr/bin/env sh | ||
|
|
||
| # Exit if any subcommand fails | ||
| set -e |
There was a problem hiding this comment.
Can we set -ex and remove the echos below?
There was a problem hiding this comment.
Whaaat I never knew about set -x. That's cool.
Having tried it, it is slightly different than the echos:
- It shows all commands, even the
command -v misewhich is useful if you're debugging exactly what's happening, but is too verbose for navigating all the text scrolling down your terminal. - It can't do the little bits of editorializing I put in the echos (pointing out that
mix ecto.setupis in(dev), and combininglocal.hex and local.rebar)
What do you think about adding it to bin/test, but keeping the echos in bin/setup?
There was a problem hiding this comment.
Points taken! That works for me 👍
|
Whoops, I asked for a rereview but forgot to actually do the change to |
mathcolo
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task: Unspoken part of Install frontend dev tooling, I guess, now that there's frontend setup and test chores to do.
( )Has tests(x)Doesn't need tests( )Tests deferred (with justification)( )Okayed the plan for the feature (e.g. the design files, or the Asana task)( )Reviewed the feature as implemented (e.g. on dev-green, or saw screenshots)(x)No review needed