Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: none
I'm working on updating
mbta/actions/build-push-ecr
to be based ondocker/build-push-action
and adding caching via GitHub Actions. Since thedocker-additional-args
input allows for arbitrary command line flags, butdocker/build-push-action
doesn't expose such a mechanism, maintaining backwards compatibility is something of an adventure. Conveniently, this repo and Skate are the only places that passdocker-additional-args
, and both of them only use--build-arg
, so I've done some creative shell scripting to translate into the more straightforward build argsdocker/build-push-action
expects. There'll be an actual migration process eventually, but in the short term, I need to be confident my creative shell scripting actually works, which means running my branch ofmbta/actions/build-push-ecr
to deploy this repo to some dev instance so we can validate that the build args are going in as specified.This PR should not be merged, just temporarily deployed to a dev environment long enough to validate that the build args and additional tags get applied correctly. After mbta/actions#41 is merged, I'll come back and make a separate PR to actually migrate to the new build args format so I can get rid of the creative shell scripting.
Testing
I've checked the new action's shell scripting setup locally and confirmed that it should in theory work.