Update dockerfile and actions #732

PaulJKim · 2024-01-08T20:13:44Z

Summary of changes

Asana Ticket: migrate realtime-signs to Linux cluster

New Dockerfile and github actions for moving Realtime Signs to run on linux

PaulJKim · 2024-01-08T20:14:58Z

.github/workflows/dev-green.yml

+          aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
+          aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}


Realtime Signs doesn't have these secrets stored in the repo environments so I guess we'll have to add them. I thought though that we wanted to avoid saving AWS credentials in GitHub repos directly, or has that changed?

You should be using v2 which uses a different connection type to AWS: https://github.com/mbta/busloc/blob/master/.github/workflows/staging.yml#L25-L34

github-actions · 2024-01-08T20:21:02Z

Coverage of commit `3a183bb`

Summary coverage rate:
  lines......: 76.4% (1949 of 2550 lines)
  functions..: 78.3% (530 of 677 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

paulswartz

You might want to include a docker.yml to ensure that the Dockerfile builds: https://github.com/mbta/busloc/blob/master/.github/workflows/docker.yml

paulswartz · 2024-01-09T14:24:55Z

.github/workflows/dev-green.yml

+          aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
+          aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}


You should be using v2 which uses a different connection type to AWS: https://github.com/mbta/busloc/blob/master/.github/workflows/staging.yml#L25-L34

paulswartz · 2024-01-09T14:51:14Z

Dockerfile

-COPY config/runtime.exs config\\runtime.exs
-RUN mix release
+COPY config/runtime.exs config/runtime.exs
+RUN mix release linux


I got an error at this line; did you mean to also check in a change to mix.exs?

Ah yes, thank you

github-actions · 2024-01-09T16:12:28Z

Coverage of commit `8c951d9`

Summary coverage rate:
  lines......: 76.4% (1949 of 2550 lines)
  functions..: 78.3% (530 of 677 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

github-actions · 2024-01-25T21:09:56Z

Coverage of commit `2b67400`

Summary coverage rate:
  lines......: 76.4% (1948 of 2550 lines)
  functions..: 78.3% (530 of 677 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

github-actions · 2024-01-26T16:12:12Z

Coverage of commit `f969b2d`

Summary coverage rate:
  lines......: 76.4% (1949 of 2550 lines)
  functions..: 78.3% (530 of 677 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

github-actions · 2024-01-26T16:38:34Z

Coverage of commit `3023481`

Summary coverage rate:
  lines......: 76.4% (1949 of 2550 lines)
  functions..: 78.3% (530 of 677 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

github-actions · 2024-01-26T17:55:16Z

Coverage of commit `123ba1b`

Summary coverage rate:
  lines......: 76.4% (1948 of 2550 lines)
  functions..: 78.3% (530 of 677 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

github-actions · 2024-01-26T18:16:49Z

Coverage of commit `dbe5976`

Summary coverage rate:
  lines......: 76.4% (1948 of 2550 lines)
  functions..: 78.3% (530 of 677 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

This reverts commit dc625ff.

This reverts commit a302452.

…#740)" This reverts commit 3b25e14.

…#740)" (#741) This reverts commit 3b25e14.

…#739)"…" This reverts commit 1d74b3b.

…#739)"…" (#742) This reverts commit 1d74b3b.

Update dockerfile and actions

3a183bb

PaulJKim commented Jan 8, 2024

View reviewed changes

PaulJKim requested review from ianwestcott, paulswartz and a team January 8, 2024 20:15

paulswartz reviewed Jan 9, 2024

View reviewed changes

paulswartz removed the request for review from ianwestcott January 9, 2024 14:52

PaulJKim added 3 commits January 9, 2024 11:08

Add docker.yml

0f13f75

Update mix.exs

d98ece6

use v2

8c951d9

paulswartz approved these changes Jan 9, 2024

View reviewed changes

PaulJKim had a problem deploying to dev-green-linux January 25, 2024 20:10 — with GitHub Actions Failure

add permissions

2b67400

PaulJKim had a problem deploying to dev-green-linux January 25, 2024 21:04 — with GitHub Actions Failure

PaulJKim had a problem deploying to dev-green-linux January 25, 2024 21:48 — with GitHub Actions Failure

PaulJKim had a problem deploying to dev-green-linux January 25, 2024 21:56 — with GitHub Actions Failure

use snake case

f969b2d

PaulJKim had a problem deploying to dev-green-linux January 26, 2024 16:09 — with GitHub Actions Failure

kebab case

3023481

PaulJKim had a problem deploying to dev-green-linux January 26, 2024 16:35 — with GitHub Actions Failure

PaulJKim had a problem deploying to dev-green-linux January 26, 2024 17:24 — with GitHub Actions Failure

krisrjohnson21 had a problem deploying to dev-green-linux January 26, 2024 17:27 — with GitHub Actions Failure

krisrjohnson21 temporarily deployed to dev-green-linux January 26, 2024 17:36 — with GitHub Actions Inactive

Add needed permissions to dev and prod workflows

123ba1b

krisrjohnson21 temporarily deployed to dev-green-linux January 26, 2024 17:53 — with GitHub Actions Inactive

default to instance role

dbe5976

PaulJKim temporarily deployed to dev-green-linux January 26, 2024 18:18 — with GitHub Actions Inactive

PaulJKim temporarily deployed to dev-linux January 26, 2024 20:33 — with GitHub Actions Inactive

paulswartz approved these changes Jan 30, 2024

View reviewed changes

PaulJKim had a problem deploying to dev-linux February 20, 2024 16:56 — with GitHub Actions Failure

PaulJKim had a problem deploying to dev-linux February 20, 2024 21:09 — with GitHub Actions Failure

PaulJKim temporarily deployed to dev-linux February 20, 2024 21:20 — with GitHub Actions Inactive

PaulJKim merged commit dc625ff into main Mar 14, 2024
5 of 7 checks passed

PaulJKim deleted the pk/windows-to-linux branch March 14, 2024 17:12

PaulJKim added a commit that referenced this pull request Mar 14, 2024

Revert "Update dockerfile and actions (#732)"

8c4d82e

This reverts commit dc625ff.

PaulJKim mentioned this pull request Mar 14, 2024

Revert "Update dockerfile and actions" #739

Merged

PaulJKim added a commit that referenced this pull request Mar 14, 2024

Revert "Update dockerfile and actions (#732)" (#739)

a302452

This reverts commit dc625ff.

PaulJKim added a commit that referenced this pull request Mar 14, 2024

Revert "Revert "Update dockerfile and actions (#732)" (#739)"

718c70b

This reverts commit a302452.

PaulJKim added a commit that referenced this pull request Mar 14, 2024

Revert "Revert "Update dockerfile and actions (#732)" (#739)" (#740)

3b25e14

This reverts commit a302452.

PaulJKim added a commit that referenced this pull request Mar 14, 2024

Revert "Revert "Revert "Update dockerfile and actions (#732)" (#739)" (…

757b203

…#740)" This reverts commit 3b25e14.

PaulJKim added a commit that referenced this pull request Mar 14, 2024

Revert "Revert "Revert "Update dockerfile and actions (#732)" (#739)" (…

1d74b3b

…#740)" (#741) This reverts commit 3b25e14.

PaulJKim added a commit that referenced this pull request Mar 15, 2024

Revert "Revert "Revert "Revert "Update dockerfile and actions (#732)" (…

55c46a2

…#739)"…" This reverts commit 1d74b3b.

PaulJKim added a commit that referenced this pull request Mar 15, 2024

Revert "Revert "Revert "Revert "Update dockerfile and actions (#732)" (…

8e1651b

…#739)"…" (#742) This reverts commit 1d74b3b.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update dockerfile and actions #732

Update dockerfile and actions #732

PaulJKim commented Jan 8, 2024

PaulJKim Jan 8, 2024

paulswartz Jan 9, 2024

github-actions bot commented Jan 8, 2024

paulswartz left a comment

paulswartz Jan 9, 2024

paulswartz Jan 9, 2024

PaulJKim Jan 9, 2024

github-actions bot commented Jan 9, 2024

github-actions bot commented Jan 25, 2024

github-actions bot commented Jan 26, 2024

github-actions bot commented Jan 26, 2024

github-actions bot commented Jan 26, 2024

github-actions bot commented Jan 26, 2024

		aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
		aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}

Update dockerfile and actions #732

Update dockerfile and actions #732

Conversation

PaulJKim commented Jan 8, 2024

Summary of changes

PaulJKim Jan 8, 2024

Choose a reason for hiding this comment

paulswartz Jan 9, 2024

Choose a reason for hiding this comment

github-actions bot commented Jan 8, 2024

Coverage of commit 3a183bb

paulswartz left a comment

Choose a reason for hiding this comment

paulswartz Jan 9, 2024

Choose a reason for hiding this comment

paulswartz Jan 9, 2024

Choose a reason for hiding this comment

PaulJKim Jan 9, 2024

Choose a reason for hiding this comment

github-actions bot commented Jan 9, 2024

Coverage of commit 8c951d9

github-actions bot commented Jan 25, 2024

Coverage of commit 2b67400

github-actions bot commented Jan 26, 2024

Coverage of commit f969b2d

github-actions bot commented Jan 26, 2024

Coverage of commit 3023481

github-actions bot commented Jan 26, 2024

Coverage of commit 123ba1b

github-actions bot commented Jan 26, 2024

Coverage of commit dbe5976

Coverage of commit `3a183bb`

Coverage of commit `8c951d9`

Coverage of commit `2b67400`

Coverage of commit `f969b2d`

Coverage of commit `3023481`

Coverage of commit `123ba1b`

Coverage of commit `dbe5976`