Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add SCU ids to signs #745

Merged
merged 1 commit into from
Apr 11, 2024
Merged

add SCU ids to signs #745

merged 1 commit into from
Apr 11, 2024

Conversation

panentheos
Copy link
Collaborator

Summary of changes

Asana Ticket: RTS: Sign ID -> SCU IP mapping

This adds SCU ids to signs.json. This change was made programmatically, via a script which is included for review. The came from the spreadsheet in the ticket.

@github-actions GitHub Actions
Copy link

Coverage of commit 32a2f82

Summary coverage rate:
  lines......: 72.0% (1819 of 2526 lines)
  functions..: 74.9% (506 of 676 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

PaulJKim
PaulJKim approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@PaulJKim PaulJKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@panentheos panentheos merged commit 5419c2d into main Apr 11, 2024
2 checks passed
@panentheos panentheos deleted the bhw/scu-id branch April 11, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulJKim PaulJKim PaulJKim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@panentheos @PaulJKim