Last Trip of the Day phase 1 #746

PaulJKim · 2024-04-11T20:15:41Z

Summary of changes

Asana Ticket: Read in the "last train" information from transit data feed and display "end of service" information

This PR adds new state for tracking recent departures within the last hour as well as any trips that were marked as a last trip within the last hour.

It also adds logic for showing and playing visual content and audio indicating that service has ended for the night. The logic varies based on whether the source is for a single direction or two directions (platform vs mezzanine, for the most part). The logic is outlined in the Asana task.

github-actions · 2024-04-12T13:57:45Z

Coverage of commit `e6a01d6`

Summary coverage rate:
  lines......: 71.6% (1907 of 2662 lines)
  functions..: 74.2% (531 of 716 functions)
  branches...: no data found

Files changed coverage rate:
                                                             |Lines       |Functions  |Branches    
  Filename                                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================================
  lib/content/audio/service_ended.ex                         |33.3%     24|50.0%     6|    -      0
  lib/content/message/last_trip/no_service.ex                |75.0%      4|50.0%     4|    -      0
  lib/content/message/last_trip/platform_closed.ex           |50.0%      2|50.0%     4|    -      0
  lib/content/message/last_trip/service_ended.ex             |50.0%      2|50.0%     4|    -      0
  lib/content/message/last_trip/station_closed.ex            |50.0%      2|50.0%     4|    -      0
  lib/engine/last_trip.ex                                    |58.1%     62|71.4%    14|    -      0
  lib/realtime_signs.ex                                      | 100%     13| 100%     3|    -      0
  lib/signs/realtime.ex                                      |90.4%     73|92.3%    13|    -      0
  lib/signs/utilities/audio.ex                               |87.6%    121| 100%    15|    -      0
  lib/signs/utilities/messages.ex                            |79.8%     89| 100%     9|    -      0

Download coverage report

github-actions · 2024-04-12T14:58:39Z

Coverage of commit `9984b40`

Summary coverage rate:
  lines......: 71.6% (1906 of 2662 lines)
  functions..: 74.2% (531 of 716 functions)
  branches...: no data found

Files changed coverage rate:
                                                             |Lines       |Functions  |Branches    
  Filename                                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================================
  lib/content/audio/service_ended.ex                         |33.3%     24|50.0%     6|    -      0
  lib/content/message/last_trip/no_service.ex                |75.0%      4|50.0%     4|    -      0
  lib/content/message/last_trip/platform_closed.ex           |50.0%      2|50.0%     4|    -      0
  lib/content/message/last_trip/service_ended.ex             |50.0%      2|50.0%     4|    -      0
  lib/content/message/last_trip/station_closed.ex            |50.0%      2|50.0%     4|    -      0
  lib/engine/last_trip.ex                                    |58.1%     62|71.4%    14|    -      0
  lib/realtime_signs.ex                                      | 100%     13| 100%     3|    -      0
  lib/signs/realtime.ex                                      |90.4%     73|92.3%    13|    -      0
  lib/signs/utilities/audio.ex                               |87.6%    121| 100%    15|    -      0
  lib/signs/utilities/messages.ex                            |79.8%     89| 100%     9|    -      0

Download coverage report

lib/engine/last_trip.ex

panentheos · 2024-04-16T19:37:53Z

lib/signs/realtime.ex

@@ -196,6 +211,25 @@ defmodule Signs.Realtime do
    {:noreply, state}
  end

+  defp has_service_ended_for_source?(sign, source, current_time) do
+    SourceConfig.sign_stop_ids(source)
+    |> Enum.all?(&has_last_trip_departed_stop?(&1, sign, current_time))


Is all? the right logic here? For the signs with multiple stops, I'd assume that trains would stop at one of them, not pass through them all.

Also, how are multiple routes (e.g. GL branches) handled? Do they each get their own last train?

Ah that's a good call out, it would be just one stop id and not all. And good question about the multiple branches too, I'll ask the transit data team about that one.

So about routes, I'm not sure if it's something we need/want to handle right now as GL last trips are not going to be supported until last trips are a feature in Glides. It does sound like once it's implemented though, that it will be a last trip for every route, which means that we would probably need to key recent departures on stop_id + route, instead of just stop_id. It's not much more effort to include the route right now though so we can also just go ahead and do it to prepare for the future.

The routes discussion brings up an interesting case though. Since the red line has branching, there will be two last trips in both directions, but there aren't GTFS route_ids for the two red line branches so somehow the code will need to know to wait for two last trips at RL trunk stops, and just one for RL branch stops..

Hmm, interesting. I guess we'll need a special case there, since I don't think there's semantic info we could leverage at those stops.

lib/signs/utilities/messages.ex

panentheos · 2024-04-17T12:19:15Z

lib/signs/utilities/messages.ex

+
+      has_top_service_ended? ->
+        if get_message_length(bottom_message) <= 18 do
+          {bottom_message,


This works fine for typical mezzanine modes, but it doesn't handle cases where the lines no longer correspond 1-1 with the source configs, like combined headways, combined alerts, or JFK special paging. I think we'll need to take a similar approach to the early AM logic, and unpack those cases so we can handle them more holistically.

I think at this point in the logic, the only case where the lines don't correspond 1-1 anymore is the JFK Mezzanine case where we have a NB platform prediction alongside SB headways. We could account for that specific case and unpack them into a regular prediction struct and paging headway struct respectively. I think at that point, the rest of the logic here would work. What are your thoughts on that or do you see a bug in that logic that I might've missed?

One case I ran into was if a mezzanine sign comes up with no predictions, it can display a two-line combined headway message, which can then get sliced in half if one direction is LTOD. I think a similar thing can happen with alerts, though I didn't check that definitively.

Ah right the headways is one that doesn't work. I wonder if the alerts case is something we can just pass along though considering that if in any case a MZ sign is showing a two-lined alert message, I believe that means service is definitely not running at that station and saying "No service use shuttle bus" or just simply "No service" essentially means the same thing as something like "Station closed service has ended for the night". Might be something to run by a PM/Designer.

Spoke with Dan and we decided that for two-line combined alerts, we should show LTOTD message once service has fully ended. Otherwise, just show the alert.

panentheos

Overall this looks good. All the comments below are small things, and the only one that affects visible behavior is the one about not suppressing predictions in the platform case.

I spot-checked a few cases locally, but did not do extensive local testing.

lib/signs/realtime.ex

lib/engine/last_trip.ex

lib/signs/realtime.ex

lib/engine/last_trip.ex

lib/predictions/last_trip.ex

lib/signs/utilities/last_trip.ex

lib/engine/last_trip.ex

lib/content/audio/service_ended.ex

Co-authored-by: Brett Heath-Wlaz <[email protected]>

…igns into pk/ltotd-phase-1

…e time

PaulJKim added 11 commits March 25, 2024 11:48

Add new engine that watches prediction for last trips

122a95d

include cleanup logic

17d325e

update engine api

df352ec

Calculate service statuses

02b68ad

Add textual messaging

d2f7a4a

Add audio

cc983a8

make conditions for getting last trip messages more explicit

556e2f5

add unit tests

bbf1d6d

Merge branch 'main' into pk/ltotd-phase-1

739743f

implement to_tts

3b883b3

dialyzer

e6a01d6

PaulJKim requested a review from panentheos April 12, 2024 14:01

default to tts

9984b40

panentheos reviewed Apr 17, 2024

View reviewed changes

Address PR feedback

473e2f6

PaulJKim temporarily deployed to dev-green-linux April 25, 2024 03:50 — with GitHub Actions Inactive

Don't need to store route_id

cb25ac7

PaulJKim temporarily deployed to dev-green-linux April 25, 2024 21:31 — with GitHub Actions Inactive

panentheos approved these changes Apr 29, 2024

View reviewed changes

PaulJKim and others added 4 commits April 29, 2024 16:16

jfk umass platforms should only see one last trip

4f8f8fc

Update lib/signs/utilities/last_trip.ex

946a8cd

Co-authored-by: Brett Heath-Wlaz <[email protected]>

address PR feedback

7767e3b

Merge branch 'pk/ltotd-phase-1' of https://github.com/mbta/realtime_s…

76e1a5c

…igns into pk/ltotd-phase-1

PaulJKim temporarily deployed to dev-green-linux April 30, 2024 02:58 — with GitHub Actions Inactive

PaulJKim added 4 commits April 30, 2024 11:25

remove IO.inspect()

5b21398

Use vehicle location as a way to track departures instead of departur…

9695750

…e time

remove unused attribute

9edf03e

fix unit test

54db789

PaulJKim temporarily deployed to dev-green-linux May 1, 2024 20:54 — with GitHub Actions Inactive

Omit red line and blank if one mz line is empty

6bd007a

PaulJKim temporarily deployed to dev-green-linux May 7, 2024 19:01 — with GitHub Actions Inactive

PaulJKim merged commit 27bd645 into main May 8, 2024
3 checks passed

PaulJKim deleted the pk/ltotd-phase-1 branch May 8, 2024 17:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Last Trip of the Day phase 1 #746

Last Trip of the Day phase 1 #746

PaulJKim commented Apr 11, 2024

github-actions bot commented Apr 12, 2024

github-actions bot commented Apr 12, 2024

panentheos Apr 16, 2024

PaulJKim Apr 17, 2024

PaulJKim Apr 18, 2024

panentheos Apr 19, 2024

panentheos Apr 17, 2024

PaulJKim Apr 23, 2024

panentheos Apr 23, 2024

PaulJKim Apr 24, 2024

PaulJKim Apr 24, 2024

panentheos left a comment

Last Trip of the Day phase 1 #746

Last Trip of the Day phase 1 #746

Conversation

PaulJKim commented Apr 11, 2024

Summary of changes

github-actions bot commented Apr 12, 2024

Coverage of commit e6a01d6

github-actions bot commented Apr 12, 2024

Coverage of commit 9984b40

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

panentheos left a comment

Choose a reason for hiding this comment

Coverage of commit `e6a01d6`

Coverage of commit `9984b40`