Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add update queues for SCUs #747

Merged
merged 1 commit into from
Apr 22, 2024
Merged

add update queues for SCUs #747

merged 1 commit into from
Apr 22, 2024

Conversation

panentheos
Copy link
Collaborator

Summary of changes

Asana Ticket: RTS: Support communication with new SCU app

Adds new processes for communicating with SCUs. Each SCU gets its own independent queue, using GenStage to simplify queueing and message passing. Expects to receive a new environment variable containing the mapping from SCU id to ip address, which will be provided separately.

Note that while this does add the processes themselves, they don't currently do anything because nothing is trying to call out to the new SCU app.

Copy link

Coverage of commit 5929e1f

Summary coverage rate:
  lines......: 71.3% (1828 of 2563 lines)
  functions..: 74.6% (513 of 688 functions)
  branches...: no data found

Files changed coverage rate:
                                                             |Lines       |Functions  |Branches    
  Filename                                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================================
  lib/pa_ess/scu_queue.ex                                    |66.7%      6|66.7%     6|    -      0
  lib/pa_ess/scu_updater.ex                                  | 7.1%     28|40.0%     5|    -      0
  lib/realtime_signs.ex                                      | 100%     15| 100%     3|    -      0
  lib/signs/utilities/signs_config.ex                        |95.5%     22|83.3%     6|    -      0

Download coverage report

[
{"Content-type", "application/json"},
{"x-api-key", sign_ui_api_key},
{"x-scu-id", scu_id}
Copy link
Collaborator

@PaulJKim PaulJKim Apr 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, why do we need to send the scu_id to Signs UI as a header?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This endpoint doesn't exist yet, but Signs UI will need this in order to attribute the data to the right sign, since the payload itself is not sufficient to differentiate it globally.

@panentheos panentheos merged commit 1dbe364 into main Apr 22, 2024
2 checks passed
@panentheos panentheos deleted the bhw/scu-queue branch April 22, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants