Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify "End of service" text to specify routes and/or directions #759

Merged

Conversation

sloanelybutsurely
Copy link
Contributor

@sloanelybutsurely sloanelybutsurely commented Jun 4, 2024

Summary of changes

Asana Ticket: Modify "End of service" text to specify routes and/or directions

Updates Last Trip messages to add additional context w/r/t route or direction when possible.

Reviewer Checklist

  • Meets ticket's acceptance criteria
  • Any new or changed functions have typespecs No changes to functions
  • Tests were added for any new functionality (don't just rely on Codecov)
  • This branch was deployed to the staging environment and is currently running with no unexpected increase in warnings, and no errors or crashes (compare on Splunk: staging vs. prod)
    • Reviewed 24hr period ending at 2024-06-06 09:00 Eastern. No additional errors in dev as compared to prod

Changes message from

    Platform closed
    Service ended for night

      to

    Service ended
    No <headsign> trains
Changes message from

    Station closed
    Service ended for night

      to

    No <line>
    Service ended for night
@sloanelybutsurely sloanelybutsurely marked this pull request as ready for review June 4, 2024 16:56
@mbta mbta deleted a comment from github-actions bot Jun 4, 2024
@mbta mbta deleted a comment from github-actions bot Jun 4, 2024
@mbta mbta deleted a comment from github-actions bot Jun 4, 2024
@sloanelybutsurely sloanelybutsurely force-pushed the sloane/direction-aware-end-of-service-messages branch from a799010 to 137cc1d Compare June 4, 2024 20:04
@sloanelybutsurely sloanelybutsurely force-pushed the sloane/direction-aware-end-of-service-messages branch from 137cc1d to fe2c9d2 Compare June 4, 2024 20:33
Copy link

github-actions bot commented Jun 4, 2024

Coverage of commit fe2c9d2

Summary coverage rate:
  lines......: 70.9% (1936 of 2729 lines)
  functions..: 72.5% (542 of 748 functions)
  branches...: no data found

Files changed coverage rate:
                                                             |Lines       |Functions  |Branches    
  Filename                                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================================
  lib/content/audio/service_ended.ex                         |42.9%     21|42.9%     7|    -      0
  lib/content/message/last_trip/platform_closed.ex           |50.0%      2|50.0%     4|    -      0
  lib/content/message/last_trip/service_ended.ex             |75.0%      4|50.0%     4|    -      0
  lib/content/message/last_trip/station_closed.ex            |75.0%      4|50.0%     4|    -      0
  lib/signs/utilities/last_trip.ex                           |88.4%     43| 100%     5|    -      0

Download coverage report

Copy link
Collaborator

@PaulJKim PaulJKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sloanelybutsurely sloanelybutsurely merged commit 601a679 into main Jun 5, 2024
2 checks passed
@sloanelybutsurely sloanelybutsurely deleted the sloane/direction-aware-end-of-service-messages branch June 5, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants