Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix several audio issues #767

Merged
merged 1 commit into from
Jun 13, 2024
Merged

fix several audio issues #767

merged 1 commit into from
Jun 13, 2024

Conversation

panentheos
Copy link
Collaborator

Summary of changes

This fixes three audio issues:

  1. When partial early AM suppression on a mezzanine sign results in two headway messages, the resulting combined message ends up with both a destination and routes. The headway TTS audio code wasn't accounting for that possibility, resulting in a crash.
  2. In the same case as above, the non-TTS audio code was using a slightly different algorithm than the text code, resulting in a headway readout using the top line's destination, instead of the route name.
  3. The TTS audio code for station-level service ended messages was still saying "This station is closed" instead of using the line name.

@panentheos panentheos requested a review from a team June 11, 2024 19:22
Copy link

Coverage of commit e48a9ed

Summary coverage rate:
  lines......: 73.3% (2024 of 2761 lines)
  functions..: 75.4% (567 of 752 functions)
  branches...: no data found

Files changed coverage rate:
                                                             |Lines       |Functions  |Branches    
  Filename                                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================================
  lib/content/audio/service_ended.ex                         |86.4%     22|71.4%     7|    -      0
  lib/content/audio/vehicles_to_destination.ex               |36.6%     41| 100%     9|    -      0

Download coverage report

Copy link
Contributor

@cmaddox5 cmaddox5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@panentheos panentheos merged commit 98292d0 into main Jun 13, 2024
2 checks passed
@panentheos panentheos deleted the bhw/audio-fixes branch June 13, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants