chore: update lab sign definitions #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The zone code that was actually set up for this sign turned out to be `n` rather than `m`. The second daisy-chained sign is also separately addressable as zone `s`, so we add a configuration for it too. * `n` is a copy of `state_blue_mezzanine` * `s` is a copy of `state_blue_eastbound`
digitalcora
force-pushed
the
cfg-test-signs
branch
from
7f6012c
to
456c009
Compare
cmaddox5
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The zone code that was actually set up for this sign turned out to be
nrather thanm. The second daisy-chained sign is also separately addressable as zones, so we add a configuration for it too.nis a copy ofstate_blue_mezzaninesis a copy ofstate_blue_eastboundReviewer Checklist
Any new or changed functions have typespecsTests were added for any new functionality (don't just rely on Codecov)signs.jsonchanges were also made in signs_ui