Migrate from RTR to GTFS-rt #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Brett Heath-Wlaz <[email protected]>
…bta/realtime_signs into pk/migrate-from-rtr-to-gtfs-rt
PaulJKim
commented
Aug 26, 2024
Comment on lines
+158
to
+161
| defp has_departed?(prediction) do | ||
| prediction.seconds_until_departure && prediction.seconds_until_departure < 0 && | ||
| not prediction.stopped_at_predicted_stop? | ||
| end |
There was a problem hiding this comment.
Flagging for review: This is new logic since the first attempt at migrating for more accurately filtering out departed trains.
PaulJKim
commented
Aug 26, 2024
cmaddox5
temporarily deployed
to
dev-green-linux
GitHub Actions
Inactive
PaulJKim
temporarily deployed
to
dev-green-linux
GitHub Actions
Inactive
PaulJKim
had a problem deploying
to
dev-green-linux
GitHub Actions
Failure
PaulJKim
temporarily deployed
to
dev-green-linux
GitHub Actions
Inactive
sloanelybutsurely
requested review from
a team and
sloanelybutsurely
and removed request for
sloanelybutsurely
digitalcora
reviewed
Nov 22, 2024
| ), | ||
| vehicle_positions_url: | ||
| System.get_env( | ||
| "VEHICLE_POSITIONS_URL", | ||
| "https://s3.amazonaws.com/mbta-gtfs-s3/rtr/VehiclePositions_enhanced.json" | ||
| "https://s3.amazonaws.com/mbta-gtfs-s3/concentrate/VehiclePositions_enhanced.json" |
There was a problem hiding this comment.
Just a drive-by note, these have "official" public-facing URLs which are behind a CDN. We ended up using these in Screens LTOTD tracking rather than these internal S3 bucket URLs.
There was a problem hiding this comment.
Sounds good to me, thanks for calling that out. Does Screens LTOTD also use dev/dev-blue versions of the CDN URLs as well?
There was a problem hiding this comment.
Only the production feeds have CDN URLs as far as I know — if we're fetching a non-prod feed those will probably have to still use S3 bucket URLs.
panentheos
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: Redeploy RTS Migration to Concentrate
This PR changes the predictions parsing logic so that we can read from the GTFS-rt feed instead of RTR.
This was previously attempted with #743 but after seeing some issues with
BRDpredictions and passthrough announcements, we had to rollback and do some investigation.Following the investigation, some flaws in the filtering logic were uncovered so this new PR includes a minor adjustments which helps us more accurately filter out predictions where a train has already departed.
Note
There are still some things regarding passthrough announcements that need to be worked out before this PR can be merged which are described in this ticket