announce four-car trains #883
Conversation
|
|
||
| [the_next_or_following] ++ train ++ prefix ++ status ++ suffix ++ followup | ||
| [the_next_or_following] ++ train ++ prefix ++ status ++ suffix ++ followup ++ four_cars |
There was a problem hiding this comment.
followup here is possibly something like "we will announce the platform for boarding soon", so does it make sense to then say "move to the front of the platform to board", when riders don't yet know which platform they should move to the front of?
There was a problem hiding this comment.
Fortunately (?) that followup message will only trigger on the JFK mezzanine, where we don't do passive readouts for four-car predictions. So as of now, this won't be an issue, but this is a good callout because there's a lot of stuff piling up here, and we could easily back ourselves into some nonsensical messaging if we're not careful about it.
There was a problem hiding this comment.
that followup message will only trigger on the JFK mezzanine, where we don't do passive readouts for four-car predictions
Since I didn't see JFK-specific logic in these changes, I'm guessing this is because of a general property of mezzanine signs, but I'm not quite connecting the dots. EDIT: covered in below comments!
| Enum.take(message.predictions, if(multiple?, do: 1, else: 2)) | ||
| four_cars? = | ||
| hd(message.predictions) |> PaEss.Utilities.prediction_four_cars?() and !multiple? and | ||
| !message.terminal? |
There was a problem hiding this comment.
We're doing this same four_cars? and !multiple? and !terminal? conditional in two different places — I think it's actually a different struct in each, so maybe there's no easy way to avoid this, unless they already implement a common protocol/behaviour. (Maybe they should?)
There was a problem hiding this comment.
Yeah, I thought about that, but the context is a bit different in each place, so there wasn't an obvious way to abstract it without making things less clear.
Summary of changes
Asana Ticket: Approaching announcement for 4-car trains
Asana Ticket: New PA/ESS state when next train is 4-car
This modifies the approaching announcement and prediction rendering to include special messages for 4-car trains. See tickets for full details.