Modified approaching announcement window from 30-45 to 0-45 seconds #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panentheos
approved these changes
Feb 25, 2025
lib/pa_ess/utilities.ex
Outdated
| @@ -552,7 +552,7 @@ defmodule PaEss.Utilities do | |||
| @spec prediction_approaching?(Predictions.Prediction.t(), boolean()) :: boolean() | |||
| def prediction_approaching?(prediction, terminal?) do | |||
| !terminal? and !prediction.stopped_at_predicted_stop? and | |||
| prediction_seconds(prediction, terminal?) in 31..45 | |||
| prediction_seconds(prediction, terminal?) in 1..45 | |||
There was a problem hiding this comment.
Predictions can go all the way down to 0, so let's make this 0..45 just to avoid any surprise edge cases in the future.
- Fixed tests associated with it, now calls approaching message with two ARR on a sign
deanshi
force-pushed
the
deanshi/change_approaching_message_time
branch
from
efb80a7 to
3c9af28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: Prevent predictions from skipping approaching messages
Modified approaching announcement window from 30-45 to 0-45 seconds
Reviewer Checklist
signs.jsonwas changed, there is a follow-up PR tosigns_uito update its dependency on this project