Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update detour serde validation check #2949

Merged
merged 7 commits into from
Feb 12, 2025
Merged

Update detour serde validation check #2949

merged 7 commits into from
Feb 12, 2025

Conversation

bfauble
Copy link
Contributor

@bfauble bfauble commented Jan 31, 2025

@bfauble bfauble requested a review from a team as a code owner January 31, 2025 15:19
@bfauble bfauble requested review from hannahpurcell and removed request for a team January 31, 2025 15:19
hannahpurcell
hannahpurcell approved these changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@hannahpurcell hannahpurcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

lib/skate/detours/snapshot_serde.ex Show resolved Hide resolved
hannahpurcell
hannahpurcell approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@hannahpurcell hannahpurcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bfauble bfauble merged commit b8b3f65 into main Feb 12, 2025
9 checks passed
@bfauble bfauble deleted the bf-serde-detour-validation branch February 12, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahpurcell hannahpurcell hannahpurcell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bfauble @hannahpurcell