Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 내 정보 수정 페이지에서 이미지가 존재하지 않는 경우 api가 호출되지 않도록 수정하라 #542

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

saseungmin
Copy link
Member

  • 내 정보 수정 페이지에서 이미지가 존재하지 않는 경우 api가 호출되지 않도록 수정

- 내 정보 수정 페이지에서 이미지가 존재하지 않는 경우 api가 호출되지 않도록 수정
@vercel
Copy link

vercel bot commented Oct 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
soople ✅ Ready (Inspect) Visit Preview Oct 13, 2022 at 2:57PM (UTC)

@saseungmin saseungmin linked an issue Oct 13, 2022 that may be closed by this pull request
@saseungmin saseungmin added the Bugfix/Function Fix to bug and isn't working label Oct 13, 2022
@github-actions
Copy link

Bundle Sizes

Compared against 0fc3bf8

Route: No significant changes found

Dynamic import: No significant changes found

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (be0e3e2) compared to base (0fc3bf8).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #542   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          197       197           
  Lines         3618      3620    +2     
  Branches       406       407    +1     
=========================================
+ Hits          3618      3620    +2     
Impacted Files Coverage Δ
src/containers/myInfo/MyInfoSettingContainer.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

⚡️ 1 Lighthouse report!

Category Score
🔴 Performance 41
🟢 Accessibility 90
🟢 Best Practices 92
🟢 SEO 100
🟠 PWA 80
Category Score
🟢 First Contentful Paint 1.6 s
🔴 Time to Interactive 9.6 s
🟠 Speed Index 3.7 s
🔴 Total Blocking Time 1,370 ms
🔴 Largest Contentful Paint 11.2 s
🟢 Cumulative Layout Shift 0

⚡️ 2 Lighthouse report!

Category Score
🔴 Performance 42
🟢 Accessibility 90
🟢 Best Practices 92
🟢 SEO 100
🟠 PWA 80
Category Score
🟢 First Contentful Paint 1.6 s
🔴 Time to Interactive 9.3 s
🟠 Speed Index 3.5 s
🔴 Total Blocking Time 1,290 ms
🔴 Largest Contentful Paint 11.0 s
🟢 Cumulative Layout Shift 0

⚡️ 3 Lighthouse report!

Category Score
🔴 Performance 39
🟢 Accessibility 90
🟢 Best Practices 92
🟢 SEO 100
🟠 PWA 80
Category Score
🟢 First Contentful Paint 1.6 s
🔴 Time to Interactive 9.4 s
🟠 Speed Index 4.0 s
🔴 Total Blocking Time 1,630 ms
🔴 Largest Contentful Paint 11.2 s
🟢 Cumulative Layout Shift 0

@saseungmin saseungmin merged commit ca4eedf into main Oct 13, 2022
@saseungmin saseungmin deleted the fix/issue-519 branch October 13, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix/Function Fix to bug and isn't working size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

내 정보 수정 > 이미지 삭제 로직 추가
1 participant