Simplify world blacklist loading #4638
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBusyBiscuit
suggested changes
Sep 24, 2021
There was a problem hiding this comment.
Some nitpickings.
I highly urge you to look into that Locale issue though.
This can lead to a lot of unexpected results and issues down the line if it gets overlooked.
If you need any documents outlining this particular issue, I'd recommend you to give this a read: https://wiki.sei.cmu.edu/confluence/display/java/STR02-J.+Specify+an+appropriate+locale+when+comparing+locale-dependent+data
TheBusyBiscuit
suggested changes
Dec 27, 2021
|
|
||
| while((currentLine = reader.readLine()) != null) | ||
| if (!currentLine.isEmpty()) | ||
| blacklist.add(currentLine.toLowerCase()); |
There was a problem hiding this comment.
Suggested change
| blacklist.add(currentLine.toLowerCase()); | |
| blacklist.add(currentLine.toLowerCase(Locale.ROOT)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly just a bit of refactoring, this PR makes world blacklist loading a lot simpler/better readable.
Also adds isWorldBlacklisted(String) which isn't used anywhere, but potentially useful for anyone hooking into mcMMO.