Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix display error on nightly #160

Merged
merged 4 commits into from
Oct 30, 2024
Merged

fix display error on nightly #160

merged 4 commits into from
Oct 30, 2024

Conversation

kpobrien
Copy link
Contributor

@kpobrien kpobrien commented Oct 30, 2024 •
edited by mcabbott
Loading

Implement the fix for the display error on nightly as discussed in #159. This PR would close that issue.

[Edit: closes #159]

mcabbott
mcabbott approved these changes Oct 30, 2024
View reviewed changes
Copy link
Owner

@mcabbott mcabbott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm slightly horrified that this works, but it does seem to!

src/show.jl Outdated Show resolved Hide resolved
@mcabbott mcabbott merged commit e98481c into mcabbott:master Oct 30, 2024
4 of 7 checks passed
@mcabbott
Copy link
Owner

Thanks!

@kpobrien kpobrien deleted the iterate_nightly_fix branch October 30, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcabbott mcabbott mcabbott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error displaying KeyedArray on nightly
2 participants
@kpobrien @mcabbott