Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ feat: add a new
bs.string
module #283base: master
Are you sure you want to change the base?
✨ feat: add a new
bs.string
module #283Changes from 35 commits
bd06af0
8c69154
9cc7a31
cb9862a
2f43498
5f64ab5
335fd3d
00cca8a
44f2c45
580983a
4db63f9
555a606
d9077fd
309928a
2b26144
69e6fe9
aed388e
b3ff5f1
f7a1f02
0199d4b
405012d
3d9ad42
8cc7109
d945eab
9896b61
ba5d1ac
6e80ee4
3a03178
f98f2e5
dbb9ef1
75c19ba
236c908
2a10868
cca563d
fa0236d
1c555e2
8c85be3
20bcfa0
e6625d6
0521187
dc6bd3c
ca135cc
c89efd4
567099a
1b6232e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We try to have a small description, a banner image, and a quote for our module. Nothing is mandatory except the description, but it's better with all of them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how you find the image for the module with a black and white variant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either have a png with transparent background, or make 2 versions. If you don't really feel like doing some image design we'll try to do it (either Theo or me)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
at the end.Converts
should beConvert
instead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really consistent with other comments, we should always add a space after
#
. Also not sure this one is really needed since the code is self explanatory. We don't really have conventions for comments but i think it's best to be consistent across a module (like for example if you use uppercase at the start of comments use it everywhere)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should remove both input and outputs when unloading the module also the const score
Check failure on line 1 in modules/bs.string/data/bs.string/function/concat/binary.mcfunction
Missing header
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've run some benchmarks because i was a bit afraid the size of these generated functions could also have an impact, and found out that the sweet spot for performances is 256. So we should remove everything above and let the function loop