-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: special case CloudFlare client IP addrs #148
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, this makes sense to me. Left a couple of very nit-picky style change requests below, let me know if they make sense to you!
Codecov Report
@@ Coverage Diff @@
## main #148 +/- ##
=======================================
Coverage 98.04% 98.04%
=======================================
Files 8 8
Lines 1585 1588 +3
=======================================
+ Hits 1554 1557 +3
Misses 22 22
Partials 9 9
|
Oh, also, please add a test case for this to the existing unit tests for getClientIP in helpers_test.go. (I expect our code coverage checks are gonna complain about this!) |
I have done this request from web editor :) Ok. Your nits are awesome! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM pending CI run
@mccutchen Please tell when this functionality would be in docker image? |
Released in https://github.com/mccutchen/go-httpbin/releases/tag/v2.11.1. A docker image for that release will be pushed as soon as this workflow run finishes. |
Docker image for |
No description provided.