Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build docker images with buildx #614

Closed
MrMondrian opened this issue Aug 22, 2024 · 3 comments
Closed

build docker images with buildx #614

MrMondrian opened this issue Aug 22, 2024 · 3 comments
Assignees

Comments

@MrMondrian
Copy link
Contributor

MrMondrian commented Aug 22, 2024

The images currently hosted on docker hub are built only for amd64, but they need to be rebuilt for amd64 AND arm64 to accommodate mac users when they return. Only need to do this for base sim and poolside (in that order).

someone must've forgotten to use buildx at comp then pushed and since we all had amd64 machines no one noticed

instructions can be found here

@majdkhalife majdkhalife self-assigned this Sep 4, 2024
@majdkhalife
Copy link
Collaborator

Its done.
I can write out steps for people and add it in the wiki in case this would happen again? What do you think

@MrMondrian
Copy link
Contributor Author

Yes I agree, its a really easy mistake to make. Most peoples instincts is to either run docker build or docker compose build but neither invoke buildx

@MrMondrian
Copy link
Contributor Author

MrMondrian commented Sep 5, 2024

It might be possible to get docker compose build to cross compile by using the platform option https://github.com/compose-spec/compose-spec/blob/main/spec.md#platform and passing --builder as a command line arguments to docker compose build but not sure if this is possible or really all that useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants