Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from chacha20-poly1305-aead to chacha20poly1305 in the default resolver #76

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Switch from chacha20-poly1305-aead to chacha20poly1305 in the default resolver #76

merged 1 commit into from
Feb 12, 2020

Conversation

expenses
Copy link
Contributor

@expenses expenses commented Feb 7, 2020 •
edited
Loading

Hi, chacha20-poly1305-aead hasn't been updated for 4 years, so we should switch to chacha20poly1305 which is actively maintained.

@expenses expenses mentioned this pull request Feb 7, 2020
Merged
@tarcieri
Copy link
Contributor

tarcieri commented Feb 7, 2020

Nice, see also this PR to add XChaCha20Poly1305 using the chacha20poly1305 crate: #73

mcginty
mcginty requested changes Feb 8, 2020
View reviewed changes
Copy link
Owner

@mcginty mcginty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I'm excited to switch to the RustCrypto crates so that the default resolver also has actively-maintained crypto implementations.

@mcginty mcginty mentioned this pull request Feb 8, 2020
Closed
7 tasks
@expenses expenses requested a review from mcginty February 10, 2020 12:09
@mcginty
Copy link
Owner

mcginty commented Feb 11, 2020

Looks so much cleaner than the past implementation we were using, thank you!!

mcginty
mcginty approved these changes Feb 11, 2020
View reviewed changes
Copy link
Owner

@mcginty mcginty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. If you'd kindly rebase again against the latest master, let's get this merged.

@expenses
Copy link
Contributor Author

@mcginty done.

@mcginty mcginty merged commit 4ee48a4 into mcginty:master Feb 12, 2020
@mcginty
Copy link
Owner

mcginty commented Feb 12, 2020

Merged and edited your commit message to match the PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcginty mcginty mcginty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@expenses @tarcieri @mcginty