Add authentication from config.json file #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the improvement. I'll have to check it out in more detail and
hopefully merge tomorrow.
…On Tue, May 16, 2017, 3:49 AM Eric Muellenbach ***@***.***> wrote:
Hi,
I really like your tool, but I thought it might be cleaner to separate the
login with AWS and the Registry Authentication. So I wrote an integration
to read the users config.json file in order to copy images between two
registries that have authentication enabled.
------------------------------
You can view, comment on, or merge this pull request online at:
#2
Commit Summary
- Add authentication from config.json file
File Changes
- *M* main.go
<https://github.com/mdlavin/copy-docker-image/pull/2/files#diff-0>
(78)
- *M* vendor/vendor.json
<https://github.com/mdlavin/copy-docker-image/pull/2/files#diff-1>
(270)
Patch Links:
- https://github.com/mdlavin/copy-docker-image/pull/2.patch
- https://github.com/mdlavin/copy-docker-image/pull/2.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGhlywP2iDsp8BDudwzSLRUhDWwnThkks5r6VTqgaJpZM4NcHVz>
.
|
mdlavin
reviewed
May 18, 2017
There was a problem hiding this comment.
Does the config.json have support for working seamlessly with ECR or does it require a step before using copy-docker-image? I'm ok with making copy-docker-image more flexible to allow external authentication in addition to automatic ECR auth, but I don't want to lose the nice experience of letting the AWS take care of auth automatically.
| } | ||
|
|
||
| registry, err := registry.New(url, username, password) | ||
| registry, err := registry.NewInsecure(url, username, password) |
There was a problem hiding this comment.
Switching to allow insecure connections seems like a dangerous thing to me. Can this be switched back to New instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I really like your tool, but I thought it might be cleaner to separate the login with AWS and the Registry Authentication. So I wrote an integration to read the users config.json file in order to copy images between two registries that have authentication enabled.