Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve search.search() examples #36081

Closed
wants to merge 2 commits into from
Closed

Improve search.search() examples #36081

wants to merge 2 commits into from

Conversation

def00111
Copy link
Contributor

@def00111 def00111 commented Sep 27, 2024

Get all search engines and check if the specified search engine is defined to the browser instead of using try/catch.

Description

Motivation

Additional details

Related issues and pull requests

Get all search engines and check if the search engine is defined to the browser instead of using try/catch.
@def00111 def00111 requested a review from a team as a code owner September 27, 2024 16:58
@def00111 def00111 requested review from jpmedley and removed request for a team September 27, 2024 16:58
@github-actions github-actions bot added Content:WebExt WebExtensions docs size/s [PR only] 6-50 LoC changed labels Sep 27, 2024
Copy link
Contributor

github-actions bot commented Sep 27, 2024

Preview URLs

(comment last updated: 2024-11-27 22:43:17)

@Josh-Cena Josh-Cena requested review from rebloor and removed request for jpmedley November 16, 2024 07:17
@rebloor
Copy link
Contributor

rebloor commented Nov 28, 2024

@def00111 many thanks for your contribution. However, after reviewing this internally with the Web extensions team, the preference is to retain the try/catch version

@rebloor rebloor closed this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebExt WebExtensions docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants