Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the sample code in the Location hash property #37022

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

T34-active
Copy link
Contributor

@T34-active T34-active requested a review from a team as a code owner November 29, 2024 01:27
@T34-active T34-active requested review from wbamberg and removed request for a team November 29, 2024 01:27
@github-actions github-actions bot added Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed labels Nov 29, 2024
Copy link
Contributor

github-actions bot commented Nov 29, 2024

Preview URLs

(comment last updated: 2024-11-30 05:45:42)

console.log(anchor.hash); // '#examples'
</script>
```js
// https://developer.mozilla.org/en-US/docs/Web/API/Location/hash#examples
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'd better to describe something like the following: assume we've navigated to some-url

@@ -18,12 +18,9 @@ A string.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description above is not correct, see: #37003. We may also fix the issue here.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants