Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove the Window.updateCommands() method #37024

Merged
merged 1 commit into from
Nov 29, 2024
Merged

chore: remove the Window.updateCommands() method #37024

merged 1 commit into from
Nov 29, 2024

Conversation

yin1999
Copy link
Member

@yin1999 yin1999 commented Nov 29, 2024

Description

remove the Window.updateCommands() method

Motivation

Follow #36996, which deleted the document.

@yin1999 yin1999 requested a review from a team as a code owner November 29, 2024 01:46
@yin1999 yin1999 requested review from wbamberg and removed request for a team November 29, 2024 01:46
@github-actions github-actions bot added Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed labels Nov 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

Preview URLs

wbamberg
wbamberg approved these changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 oops, thank you @yin1999 !

@wbamberg wbamberg merged commit 6b8ddb7 into mdn:main Nov 29, 2024
7 checks passed
@yin1999 yin1999 deleted the patch-1 branch November 29, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbamberg wbamberg wbamberg approved these changes

Assignees
No one assigned
Labels
Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yin1999 @wbamberg