Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(http): Move Ogg guide, HTTP method fixes #37026

Merged
merged 7 commits into from
Dec 1, 2024

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Nov 29, 2024

A couple of small fixes for HTTP section

Changes:

  • Move Ogg guide into Media section
    • Some cleanup in Ogg guide
  • Browser compat information about HTTP methods.
  • Update a few links
    • Node docs
    • web.dev

@bsmth bsmth requested review from a team as code owners November 29, 2024 10:33
@bsmth bsmth requested review from hamishwillee and estelle and removed request for a team November 29, 2024 10:33
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs Content:HTTP HTTP docs Content:Media Media docs size/m [PR only] 51-500 LoC changed labels Nov 29, 2024
Copy link
Contributor

github-actions bot commented Nov 29, 2024

Preview URLs (9 pages)
External URLs (5)

URL: /en-US/docs/Web/HTTP/CSP
Title: Content Security Policy (CSP)


URL: /en-US/docs/Web/HTTP/Cookies
Title: Using HTTP cookies

(comment last updated: 2024-12-01 22:36:35)

@@ -111,7 +111,8 @@ Content-Length: 1234

## Browser compatibility

{{Compat}}
The browser doesn't use the `DELETE` method for user-initiated actions, so "browser compatibility" doesn't apply.
Copy link
Collaborator

@hamishwillee hamishwillee Dec 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsmth All of these method updates "seem reasonable" - meaning I can't think of a case where a browser emits them except via a direct user API call to fetch or XHR or whatever. Nor where the response to a DELETE (or the others) is specially handled as a result of the original DELETE call. So in other words the browser doesn't really have any "DELTEE" implementation as such.

But I wouldn't have changed these without first working to get agreement and removal in BCD. Maybe you already did that? If not, can you kick it off?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I wouldn't have changed these without first working to get agreement and removal in BCD. Maybe you already did that? If not, can you kick it off?

Earlier in the year we discussed HTTP statuses and headers in BCD where support means "nothing breaks" -> the browser doesn't set them in requests and doesn't act on them in responses, but application-specific logic can be done using fetch(). I'll add this to the BCD call notes for this week to make sure this prose is okay, so thanks for flagging it 👍🏻

Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bsmth . Makes sense to me - merging.

Note #37026 (comment) - possible post-process activity

@hamishwillee hamishwillee merged commit 4d12b3e into mdn:main Dec 1, 2024
9 checks passed
@bsmth bsmth deleted the http-section-fixes branch December 2, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTML Hypertext Markup Language docs Content:HTTP HTTP docs Content:Media Media docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants