Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attributes detail for svg <view> element #37034

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Nov 30, 2024

Description

add attributes detail for svg <view> element

also remove the dom interface section to align with other pages

Motivation

Additional details

Related issues and pull requests

@github-actions github-actions bot added Content:SVG SVG docs size/s [PR only] 6-50 LoC changed labels Nov 30, 2024
Copy link
Contributor

@skyclouds2001 skyclouds2001 marked this pull request as ready for review November 30, 2024 05:51
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner November 30, 2024 05:51
@skyclouds2001 skyclouds2001 requested review from hamishwillee and removed request for a team November 30, 2024 05:51
@@ -50,10 +56,6 @@ The **`<view>`** [SVG](/en-US/docs/Web/SVG) element defines a particular view of

{{EmbedLiveSample("Example", "85ch", "240px")}}

## DOM Interface
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skyclouds2001 This is removal of useful information.

Can you create a discussion for putting this back into the template, perhaps leaning on HTML for inspiration? What I'm thinking is something like https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#technical_summary

I'll accept this now as it is consistent.

Copy link
Contributor Author

@skyclouds2001 skyclouds2001 Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could make the table generated by {{svginfo}} call also output DOM interface info, since SVGData.json already has the required data source

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skyclouds2001 That would certainly be one option, which might have many benefits. Did you want to create a discussion around this or should I?

@hamishwillee hamishwillee merged commit eb2d8ff into mdn:main Dec 1, 2024
7 checks passed
@skyclouds2001 skyclouds2001 deleted the view branch December 2, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:SVG SVG docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants