FF134 ReadableStreamBYOBReader.read() takes options.min arg #37045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishwillee
requested review from
sideshowbarker
and removed request for
a team
8 tasks
|
Preview URLs (comment last updated: 2024-12-02 23:19:47) |
sideshowbarker
approved these changes
Dec 2, 2024
Co-authored-by: sideshowbarker <[email protected]>
|
Thanks for the review @sideshowbarker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReadableStreamBYOBReader.read()now takesoptions.minargument in FF134 that allows you to specify a minimum number of elements to return each time the promise resolves while the stream is active.This adds docs for the argument, and an example.
Note that most of the new live example is deliberately hidden, but I wanted to do it this way to show how it works in practice. I've pointed readers to the using guide for more info on "the detail" of that hidden code.
Related docs work can be tracked in #36921