Replace 'the DOM load event' with 'the window load event' Issue #37047 #37073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:WebExt
|
@rebloor Could you please check and review. |
rebloor
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced 'the DOM load event' with 'the window load event' as it sounded similar to DOMContentLoaded event.Motivation
This change will help new readers to have more clarity regarding onCompleted NavigationAdditional details
Chrome docs:
https://developer.chrome.com/docs/extensions/reference/api/webNavigation#event-onCompleted
Fired when a document, including the resources it refers to, is completely loaded and initialized.
Also this is super useful to know:
Event order
For a navigation that is successfully completed, events are fired in the following order:
onBeforeNavigate -> onCommitted -> [onDOMContentLoaded] -> onCompleted
Related issues and pull requests
Fixes #37047