Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MDN feature pages for SVGAnimatedTransformList #37077

Merged
merged 9 commits into from
Dec 6, 2024
Merged

MDN feature pages for SVGAnimatedTransformList #37077

merged 9 commits into from
Dec 6, 2024

Conversation

yashrajbharti
Copy link
Contributor

part of Missing baseline pages project

@yashrajbharti yashrajbharti requested a review from a team as a code owner December 3, 2024 17:25
@yashrajbharti yashrajbharti requested review from sideshowbarker and removed request for a team December 3, 2024 17:25
@github-actions github-actions bot added Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Dec 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024 •
edited
Loading

Preview URLs

(comment last updated: 2024-12-06 07:43:08)

estelle
estelle reviewed Dec 4, 2024
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty good.

I made a suggestion on the base for adding that it reflects attributes, which attributes are reflected on which elements, and a bit more on what is returned.

files/en-us/web/api/svganimatedtransformlist/baseval/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/svganimatedtransformlist/animval/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/svganimatedtransformlist/baseval/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/svganimatedtransformlist/baseval/index.md Outdated Show resolved Hide resolved
@sideshowbarker sideshowbarker removed their request for review December 4, 2024 09:49
@yashrajbharti
Copy link
Contributor Author

Thanks a lot, I will make sure to follow them, and fix this for all the SVGAnimated PRs. I aim to write with clarity and this helps a lot!

@yashrajbharti yashrajbharti marked this pull request as draft December 4, 2024 23:30
@yashrajbharti yashrajbharti marked this pull request as ready for review December 4, 2024 23:44
@yashrajbharti yashrajbharti requested a review from estelle December 4, 2024 23:44
estelle
estelle approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

@estelle estelle merged commit 4f59a1b into mdn:main Dec 6, 2024
8 checks passed
@yashrajbharti yashrajbharti deleted the feat/svganimatedtransformlist branch December 7, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estelle estelle estelle approved these changes

Assignees
No one assigned
Labels
Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yashrajbharti @estelle