Add a note about how delegatesFocus about focusable element placement
#37101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was testing around with `delegatesFocus` and it seems that it will only delegate focus to elements that live inside the shadow dom. If you have focusable elements in the light dom, they will not get focused. Example: https://codepen.io/paramagicdev/pen/ByBjogK?editors=1010 ```html <my-element> <template shadowrootmode="open" shadowrootdelegatesfocus="true"> <slot></slot> </template> <button>Hello World</button> </my-element> ``` Call `.focus()` on `<my-element>` *will not* shift focus. However, if you embedded the "focusable part" inside the shadow dom, delegatesFocus will work as expected. ```html <my-element> <template shadowrootmode="open" shadowrootdelegatesfocus="true"> <button>Hello World</button> </template> </my-element> ```
github-actions
bot
added
Content:WebAPI
|
Preview URLs (comment last updated: 2024-12-05 01:27:54) |
wbamberg
reviewed
Dec 5, 2024
wbamberg
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was testing around with
delegatesFocusand it seems that it will only delegate focus to elements that live inside the shadow dom.If you have focusable elements in the light dom, they will not get focused.
Example:
https://codepen.io/paramagicdev/pen/ByBjogK?editors=1010
Call
.focus()on<my-element>will not shift focus.However, if you embedded the "focusable part" inside the shadow dom, delegatesFocus will work as expected.
Motivation
delegatesFocus not working for light dom elements was perplexing me.
Additional details
Related issues and pull requests