Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct typo in stroke-linejoin svg attribute page #37112

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

farskid
Copy link

@farskid farskid commented Dec 5, 2024

Description

There's a typo at https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/stroke-linejoin. it says as been instead of has been.

@farskid farskid requested a review from a team as a code owner December 5, 2024 20:49
@farskid farskid requested review from chrisdavidmills and removed request for a team December 5, 2024 20:49
@github-actions github-actions bot added Content:SVG SVG docs size/xs [PR only] 0-5 LoC changed labels Dec 5, 2024
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Preview URLs

(comment last updated: 2024-12-06 10:09:13)

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @farskid, and thank you for your contribution to MDN! I've got a suggestion for you to consider — I think this is simpler, easier to read, and still effective. I removed the link to the compat table because there is no data there for arcs to say what browsers it is supported in, so the link is not useful.

I've filed an issue on the browser-compat-data project to ask if someone can add this data to make the compat table more useful: mdn/browser-compat-data#25336.

Finally, there is an equivalent note in the miter-clip section — can you update that one, while you are here?

Thanks again!

@@ -135,7 +135,7 @@ svg {
### arcs

> [!NOTE]
> The `arcs` value as been introduced in SVG2 and it isn't widely supported yet, see [Browser compatibility](#browser_compatibility) below for details.
> The `arcs` value has been introduced in SVG2 and it isn't widely supported yet, see [Browser compatibility](#browser_compatibility) below for details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> The `arcs` value has been introduced in SVG2 and it isn't widely supported yet, see [Browser compatibility](#browser_compatibility) below for details.
> The `arcs` value was introduced in SVG2 and isn't widely supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:SVG SVG docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants