Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ::details-content page #37118

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

lukewarlow
Copy link
Contributor

Description

Add a page for the new ::details-content pseudo element.

Motivation

To help web developers discover this new feature.

Additional details

Related issues and pull requests

Depends on: mdn/interactive-examples#2874

@lukewarlow lukewarlow requested a review from a team as a code owner December 6, 2024 11:58
@lukewarlow lukewarlow requested review from chrisdavidmills and removed request for a team December 6, 2024 11:58
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels Dec 6, 2024
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Preview URLs

(comment last updated: 2024-12-11 09:17:51)

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @lukewarlow. I've got a few comments for you to consider, but nothing too major.

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukewarlow nice one.

I thought your updates looked great, but I thought the examples could use a bit of description/explanation. Because I worked on the allow-discrete animation stuff recently and it is still fresh in my head, I decided to edit the page directly and drop an explanation in. I hope that's OK with you.

I won't merge it yet, so you can check it out to make sure you are happy with it.

@chrisdavidmills
Copy link
Contributor

@lukewarlow, oooh, I also increased the transition duration to 600ms so that it is a bit easier to see what is happening. I also put the opacity transition first, as I thought it was easier to explain if I explained that one first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants