Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subtitlesMenu redeclaration in "Adding captions and subtitles to HTML video" tutorial #37128

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Fix subtitlesMenu redeclaration in "Adding captions and subtitles to HTML video" tutorial #37128

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f47078e
Fix subtitlesMenu reassignment
jacob-willden Dec 6, 2024
75c2b1a
Merge branch 'main' into main
chrisdavidmills Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../audio_and_video_delivery/adding_captions_and_subtitles_to_html5_video/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ All we need to do is to go through the video's `textTracks`, reading their prope
let subtitlesMenu;
if (video.textTracks) {
const df = document.createDocumentFragment();
const subtitlesMenu = df.appendChild(document.createElement("ul"));
subtitlesMenu = df.appendChild(document.createElement("ul"));
subtitlesMenu.className = "subtitles-menu";
subtitlesMenu.appendChild(createMenuItem("subtitles-off", "", "Off"));
for (let i = 0; i < video.textTracks.length; i++) {
Expand Down
Loading