Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(workflows/pr-review-companion): sync build to GCS as well #38380

Merged
merged 1 commit into from
Feb 28, 2025
Merged

feat(workflows/pr-review-companion): sync build to GCS as well #38380

merged 1 commit into from
Feb 28, 2025

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Feb 28, 2025

Description

Syncs PR Review Companion builds to GCS in addition to AWS.

Motivation

Prepares for the upcoming Review environment in GCP.

Additional details

Related issues and pull requests

Part of MP-1889 (Mozilla-internal).

See also:

@caugner
feat(pr-review-companion): sync to GCS
641825c 
For now, we sync in addition to AWS.
@caugner caugner requested a review from a team as a code owner February 28, 2025 18:20
@github-actions github-actions bot added system [PR only] Infrastructure and configuration for the project size/s [PR only] 6-50 LoC changed labels Feb 28, 2025
caugner
caugner commented Feb 28, 2025
View reviewed changes
Copy link
Contributor Author

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-approval, as this cannot easily be tested on the branch.

(I will test, and revert if it fails. But because these steps come after the existing ones, this shouldn't break anything.)

@caugner caugner merged commit bd35118 into main Feb 28, 2025
11 of 12 checks passed
@caugner caugner deleted the MP-1889-sync-review-build-to-gcs branch February 28, 2025 18:25
@caugner caugner changed the title feat(pr-review-companion): sync build to GCS as well feat(workflows/pr-review-companion): sync build to GCS as well Feb 28, 2025
This was referenced Feb 28, 2025
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/s [PR only] 6-50 LoC changed system [PR only] Infrastructure and configuration for the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@caugner