Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window-manipulator update for issue 431 #537

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

rebloor
Copy link
Collaborator

@rebloor rebloor commented Aug 22, 2023

Description

Amends the extension to use a sidebar so that the console output indicating a normal window has been created is guaranteed to work.

Related issues and pull requests

Fixes #431

@rebloor rebloor added bug Indicates an unexpected problem or unintended behavior. example New or updated example labels Aug 22, 2023
@rebloor rebloor requested a review from zombie August 22, 2023 04:09
@rebloor rebloor self-assigned this Aug 22, 2023
@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Sep 21, 2023
Copy link
Member

@zombie zombie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Rumyra Rumyra merged commit fa4187c into mdn:main Oct 4, 2023
2 checks passed
@rebloor rebloor deleted the window-manipulator-update-for-issue-28 branch October 4, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior. example New or updated example idle Issues and pull requests with no activity for three months.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

windows.create() promise will never be fulfilled
3 participants