Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for MV3 and Chrome compatibility #565

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dotproto
Copy link
Contributor

Updates the stored-credentials example to use Manifest V3 and to add support for Chrome. This demo now works in Firefox and Chrome. It does not work in Safari because at the moment webRequestAuthProvider is unsupported.

@@ -0,0 +1,2 @@
// Import and synchronously execute other JavaScript files.
importScripts("storage.js", "auth.js");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <no-undef> reported by reviewdog 🐶
'importScripts' is not defined.

@rebloor
Copy link
Collaborator

rebloor commented Jul 22, 2024

@dotproto This change makes the example inconsistent with the guidance in the readme file: "These examples are tested in Firefox. They may work in other browsers, if the browser supports the APIs used. Note that these examples all use the browser namespace and promises to work with asynchronous functions. This means the examples won't work in Chrome unless you use the polyfill provided by Mozilla. See the overview of WebExtension APIs for more information."
I'm wondering whether we should continue with this as an MV2, Firefox-only example unless we have plans to update all the extensions to MV3 and Chrome support. We introduced an inconsistency and potentially an expectation of updates we may not have plans to make.

@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idle Issues and pull requests with no activity for three months.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants