fix(cloud-function): disallow unauthenticated access #12710
+0
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only need internal + load balancing ingress.
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
argl
reviewed
Mar 4, 2025
| @@ -385,7 +385,6 @@ jobs: | |||
| --region=$region \ | |||
| --source=cloud-function \ | |||
| --trigger-http \ | |||
| --allow-unauthenticated \ | |||
There was a problem hiding this comment.
I suggest deploying this change to test/staging first to be sure nothing bad will happen?
Also: This looks strange:
Subsequent deployments of the same function don't change its status, even if you don't use this flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
We set
--allow-unauthenticatedwhen deploying our Cloud Function, but this does not seem to be necessary, as we're routing internally from our GCP load balancer, as confirmed by the new Review function.Solution
Remove the
--allow-unauthenticatedflag.How did you test this change?
Applied the same change on the Review function, which is deployed, and can still be accessed through the load balancer (e.g. https://main.review.mdn.allizom.net/).