feat: Changed Recipe's Last Made button to allow editing Last Made Date. #4986
+163
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PancakeZik
changed the title
…ded styles for the hover.
PancakeZik
changed the title
CloCkWeRX
reviewed
Feb 6, 2025
| max-width="290px" | ||
| min-width="auto" | ||
| > | ||
| <template #activator="{ on, attrs }"> |
CloCkWeRX
reviewed
Feb 6, 2025
| // If lastMade exists, init the date picker to that date, else set to 'today' | ||
| lastMadeEdit.value = lastMade.value | ||
| ? new Date(lastMade.value).toISOString().substring(0, 10) | ||
| : new Date().toISOString().substring(0, 10); |
There was a problem hiding this comment.
Can you just do new Date(lastMade.value).toISOString().substring(0, 10) ; because if it's null it'd back back to current date? (or pull the bit that is different - last edited || now) out to DRY?
CloCkWeRX
reviewed
Feb 6, 2025
| @@ -459,7 +459,8 @@ def update_last_made(self, slug: str, data: RecipeLastMade): | |||
| """Update a recipe's last made timestamp""" | |||
|
|
|||
| try: | |||
| recipe = self.service.update_last_made(slug, data.timestamp) | |||
| # If timestamp is None, update with None | |||
| recipe = self.service.update_last_made(slug, data.timestamp if data.timestamp is not None else None) | |||
There was a problem hiding this comment.
Wouldn't
Suggested change
| recipe = self.service.update_last_made(slug, data.timestamp if data.timestamp is not None else None) | |
| recipe = self.service.update_last_made(slug, data.timestamp) |
make more sense? If it's !!None, doesn't that mean it's None?
|
Seems mostly sensible; not having python as a daily driver the !!None thing seems a bit odd; but if it's idiomatic... great. |
|
Makes sense, thanks for that! Looking forward to having it merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently no way of changing or removing the "last made" date.
Added option in the UI to do so.
Changed API to accept null for Last Made date so it can be set back to Never.
Which issue(s) this PR fixes:
Feature Request #4974
Special notes for your reviewer:
I added some styles to RecipeLastMade.vue, but I'm not sure this is the correct place to do so?