This repository has been archived by the owner on Feb 3, 2022. It is now read-only.
- fixed addPaymentDataToRequest method, adding data to request instead of quote #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thank you for this great plugin. I tried to use it with payment method conditions, which I suppose is not used very often, as stated in documentation: https://meanbee.atlassian.net/wiki/spaces/EXT/pages/35160074/Shipping+Rules#ShippingRules-Conditions in payment conditions section. However, even after changing checkout flow, so payment method is selected before shipping method it did not work properly. I found out that getSanitisedValue method of Meanbee_Shippingrules_Model_Rule_Condition returns null for payment_method attribute, and then I found, that payment_method data is not saved to $request, but to $quote in Carrier model. I think it's a typo, and since this functionality is not 100% in scope of extension no one found it before, but maybe it will be useful for someone in the future.