This repository has been archived by the owner on Mar 4, 2021. It is now read-only.
Add functionality required by libndt #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required by and used in measurement-kit/libndt#108
Required by and used in measurement-kit/libndt#108
bassosimone
added a commit
to measurement-kit/libndt
that referenced
this pull request
Aug 2, 2019
This diff converts libndt to use mkbuild as opposed to deprecated subrepositories that we would like to decommission. It includes uncommitted changes to mkbuild required to make this conversion actually possible, see measurement-kit/mkbuild#6. It also removes conditional support for OpenSSL and cURL mainly because that simplifies the migration, _and_ because having such support as optional was optional complexity. This diff additionally changes the testing strategy in Travis to only cover the legacy code path. It appears that there have been changes again and now running several NDT tests from the same invocation of Travis has become problematic. This is reasonably okay because at this stage we're going to use libndt only as an implementation of the legacy protocol. Closes #91. Closes #92.
We'll be using a version of LibreSSL that we previously built to have a working, albeit old, "OpenSSL" for Windows. This is fine because we only use this prebuilt library for running continuous integration tests. Because LibreSSL/OpenSSL consists of multiple libraries, it was necessary here to rework how prebuilt libs work.
robertodauria
approved these changes
Sep 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code has been built locally and used to regenerate
CMakeLists.txtin measurement-kit/libndt#108.