-
-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compatibility with older browsers in zxing-js #700
Fix compatibility with older browsers in zxing-js #700
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change.
Please resync once more - I had a commit which should remove the minified file generation from npm build
.
Alternatively please revert the minified/html5-qrcode.min.js
change in this PR.
I'll generate the new one and publish to npm and Github as part of release process.
…_Use_In_Older_Browsers
Thanks for the change -- merging. |
@mebjas This change breaks html5-qrcode in modern browsers. Tested on Vivaldi 5.7.2921.63 (using V8 11.0.226.19) and Firefox 111.0. Built from source on Ubuntu and imported into a Svelte project to test. |
I am reverting this by another PR for now (#738) @bilal-elchami if you have a non breaking change later - please send another PR. |
@JL102 thanks for sharing the issue. |
@mebjas np. Try this instead: const g = (typeof globalThis !== 'undefined') ? globalThis :
(typeof global !== 'undefined') ? global :
(typeof self !== 'undefined') ? self :
(typeof window !== 'undefined') ? window : {};
var __awaiter = g.__awaiter || function ( ..... The typeof operator allows non declared variables. |
Can we get these changes merged please - #700 (comment) v2.3.8 is still throwing |
This PR fixes the described bug in this issue: #188
@all-contributors please add @bilal-elchami for this feature.