Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change classify and legacy classify default behaviors and parameters #192

Merged
merged 5 commits into from
Oct 25, 2024
Merged

Change classify and legacy classify default behaviors and parameters #192

merged 5 commits into from
Oct 25, 2024

Conversation

adraismawur
Copy link
Collaborator

This should be it? Probably?

@adraismawur adraismawur self-assigned this Oct 15, 2024
@adraismawur adraismawur marked this pull request as draft October 18, 2024 10:40
@adraismawur adraismawur changed the title swap mix and classify as defaults Change classify and legacy classify default behaviors and parameters Oct 18, 2024
@adraismawur
Copy link
Collaborator Author

More work is needed to make this all make sense. TBD after discussion

@adraismawur adraismawur assigned nlouwen and unassigned adraismawur Oct 23, 2024
@nlouwen
Copy link
Collaborator

nlouwen commented Oct 24, 2024

  • Collapsed legacy_classify into general --classify arg
  • Separated --classify arg for cluster and query
  • general code cleanup of legacy_classify terminology
  • small cli config addition to keep cluster-query-benchmark ordering in help message

@nlouwen nlouwen marked this pull request as ready for review October 24, 2024 13:43
CatarinaCarolina
CatarinaCarolina approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@CatarinaCarolina CatarinaCarolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny changes to help texts, but otherwise lgtm!

big_scape/cli/cluster_cli.py Outdated Show resolved Hide resolved
big_scape/cli/cluster_cli.py Outdated Show resolved Hide resolved
@nlouwen nlouwen merged commit 9758f67 into dev Oct 25, 2024
4 checks passed
@nlouwen nlouwen deleted the hotfix/default-classify branch October 25, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CatarinaCarolina CatarinaCarolina CatarinaCarolina approved these changes

Assignees

@nlouwen nlouwen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adraismawur @nlouwen @CatarinaCarolina