fix: cli encoding issue

[oliverqx]

description

pr to fix cli encoding issue

related issue: #1247

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
screenpipe	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 4, 2025 2:23am

[oliverqx]

@louis030195 so it took me some time to replicate consistently. I'm not sure whats causing the issue. The behaviour is wild, so its very hard to understand.

1. Encoding issue does not always occur but once it starts happening it doesn't go away.
2. Usually starts happening after running @screenpipe/dev create and ctrl+c in the middle of it ?
3. Encoding breaks ONLY for the components add command, which I also do not understand..
4. I thought it was related to prompts, the package, but even by using inquirer it does not encode well.

Only way I've been able to get it working, is by switching from brocli to Commander, so I wanted to know if you'd be okay with me doing that.

Apart from fixing the issue, commander has a wider community support. Their last release was only 2 weeks ago. It has 110M weekly downloads (brocli less than 100K). I've also been using Commander for years now and it has never presented weird encoding issues like this one

[louis030195]

@louis030195 so it took me some time to replicate consistently. I'm not sure whats causing the issue. The behaviour is wild, so its very hard to understand.

1. Encoding issue does not always occur but once it starts happening it doesn't go away.
2. Usually starts happening after running @screenpipe/dev create and ctrl+c in the middle of it ?
3. Encoding breaks ONLY for the components add command, which I also do not understand..
4. I thought it was related to prompts, the package, but even by using inquirer it does not encode well.

Only way I've been able to get it working, is by switching from brocli to Commander, so I wanted to know if you'd be okay with me doing that.

Apart from fixing the issue, commander has a wider community support. Their last release was only 2 weeks ago. It has 110M weekly downloads (brocli less than 100K). I've also been using Commander for years now and it has never presented weird encoding issues like this one

would be great to switch to commander

[oliverqx]

@louis030195 wdyt about me adding some tests? i see theres a folder already but there are no tests yet

edit: would be using jest

[louis030195]

is it mergeable?

[oliverqx]

@louis030195 it is yes. changes:

1. commander migration
2. implemented logger
3. refactored create command
4. create pipe command (for pipes)
5. create app command (for tauri/electron templates)
6. using simpleGit now for better nodejs\process support

[oliverqx]

as always, i've tested it thoroughly. Will keep an eye out for edge cases/bugs but I'm fairly sure its alright. sorry about past bugs

[oliverqx]

was thinking we could refactor DX into

1. @screenpipe/dev pipe [create,register,publish]
2. @screenpipe/dev app [create, x]

x could be some app template specific command to run, and happy to add tests if you guys want them (jest)

lmkwyt!

[louis030195]

[louis030195]

@screenpipe/dev app create [name]

make sense