Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ember-cli-update #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ember-cli-update #1

wants to merge 2 commits into from

Conversation

JonathanPrince
Copy link

No description provided.

JonForest
JonForest suggested changes Jun 6, 2019
View reviewed changes
Copy link

@JonForest JonForest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what the problem is, but I'm getting this error when I try to ember test
image

I briefly looked into it, but no dice.
I also stuck up another commit to fix a bunch of linting errors while testing.

@JonathanPrince
Copy link
Author

Oops, I'll sort it. Also noticed that NAME_KEY is still in there too 🤦‍♂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonForest JonForest JonForest requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonathanPrince @JonForest