Split fastlane build and deploy steps #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garethbowen
force-pushed
the
138-build-all-apks
branch
from
23f539b to
10a786f
Compare
|
Review please @mrsarm ! The solution I went with was to split the fastlane process into build and publish rather than doing both in one step. This means we can build all brands, then if tagging upload them all to GH, and upload a few specific ones to the Play Store. It's hard to know if this will work or not until I do a tag, but I think it should work! |
mrsarm
reviewed
Dec 7, 2020
| # - fastlane deploy flavor:vhw_burundi | ||
|
|
||
| - stage: final | ||
| # flavors sorted alphabetically with three per job |
There was a problem hiding this comment.
Nice clarification of why are separated in ~3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means we can build all apks, and publish to GitHub, without
also publishing to the Play Store.
#138
Also solves a bug where Play Store rejection meant the apks weren't
uploaded to GitHub by switching the order of release steps.
#91