Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub Actions for CI #143

Merged
merged 16 commits into from
Dec 21, 2020
Merged

Use GitHub Actions for CI #143

merged 16 commits into from
Dec 21, 2020

Conversation

garethbowen
Copy link
Member

Replace travis-ci integration with GitHub Actions.

#138
#129
#91

@garethbowen garethbowen requested a review from mrsarm December 21, 2020 03:16
@garethbowen
Copy link
Member Author

@mrsarm Please review when you get a chance. Hopefully this will make it easier to release the permissions changes you're working on.

I haven't solved publishing to Play Store, and I'm thinking about splitting that off as a separate issue because I'm not sure it's a good idea anyway, but this PR will unblock App Builders by publishing apks with the GH Release.

Copy link
Contributor

@mrsarm mrsarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add. Looks great!

Though I see in the build of this PR that GH is waiting for travis despite you did remove the travis configuration file, but I guess it is because there is some configuration in the repo that you will remove before the PR merge.

@garethbowen garethbowen merged commit 6705216 into master Dec 21, 2020
@garethbowen garethbowen deleted the 129-gh-actions branch December 21, 2020 19:07
@garethbowen
Copy link
Member Author

@mrsarm Thanks. I've merged this and changed the repo rules so it requires the GH build not the travis build. This means you'll have to rebase your branch to get it to trigger the GH build. Hopefully this speeds up your CI!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants