Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MoH Niger CHW - Generate the APK #280

Merged
merged 3 commits into from
Jun 9, 2022
Merged

MoH Niger CHW - Generate the APK #280

merged 3 commits into from
Jun 9, 2022

Conversation

ernestoteo
Copy link
Contributor

#51

@ernestoteo ernestoteo marked this pull request as ready for review June 8, 2022 08:17
@binokaryg
Copy link
Member

Have you shared the keys somewhere?

@ernestoteo
Copy link
Contributor Author

@latin-panda , I have this security error in Pre-launch report details on Google playstore console.
Capture d’écran 2022-06-09 082141

binokaryg
binokaryg approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@binokaryg binokaryg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@latin-panda
Copy link
Contributor

To cross post, we're working on the play store issue in this PR , the ticket is linked for more details. I'll let you know once the issue is fixed :)

@ernestoteo
Copy link
Contributor Author

To cross post, we're working on the play store issue in this PR , the ticket is linked for more details. I'll let you know once the issue is fixed :)

Thanks @latin-panda

@ernestoteo ernestoteo merged commit 77b380d into v1.0.x Jun 9, 2022
@ernestoteo ernestoteo deleted the v1.0.0-moh-niger-chw branch June 9, 2022 14:43
@latin-panda
Copy link
Contributor

Thank you, @ernestoteo please cherry pick this commit and send the PR to master, so this flavor gets maintained by the team :)
After the cherry pick PR is squash-merged, no more actions is required.

@ernestoteo ernestoteo restored the v1.0.0-moh-niger-chw branch June 10, 2022 08:02
@ernestoteo ernestoteo deleted the v1.0.0-moh-niger-chw branch June 10, 2022 10:27
ernestoteo added a commit that referenced this pull request Jun 10, 2022
@ernestoteo
MoH Niger CHW - Generate the APK (#280)
9287bd8 
* MoH Niger CHW - Generate the APK

* Add produciton instance URL

* Fix review feedback
latin-panda pushed a commit that referenced this pull request Jun 14, 2022
@ernestoteo
MoH Niger CHW - Generate the APK (#280) (#285)
d8051e7 
Cherry picked from 77b380d
This commit adds MoH Niger CHW flavor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiellavis hiellavis hiellavis left review comments

@adrienlemec adrienlemec adrienlemec approved these changes

@binokaryg binokaryg binokaryg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ernestoteo @binokaryg @latin-panda @hiellavis @adrienlemec