Add one intent-filter for each county in moh_kenya_echis flavor #311
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#310
b2e815f we used a new resource string which specified the host (including optional wildcard) to be used by the intent. We can't do exactly what we did in #307 because it will require a change to existing flavors. This slight variation creates two data elements for the same intent-filter. It's a bit concerning because, we're registering the following:I welcome input to confirm this is the best path available.I can't find any way to: add conditions in intent-filters, useapp_host | intent_host
, or dynamically add intents in code.The only other viable options I've found is to achieve this by overwriting AndroidManifest.xml directly for flavors which want this functionality. To achieve this, I believe we'd need to duplicate the list of urls (cannot reuse the data in instances.xml). I suspect it's not very pretty. Please let me know if there is a better way to do this!Uses AndroidManifest.xml to add intent-filters per county. moh_kenya_echis only.